Do not mutate Scan inner graph when deriving logprob #7575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
fix_scan_inplace_mutation
branch
from
ffe2b06 to
136dc1c
Compare
ricardoV94
force-pushed
the
fix_scan_inplace_mutation
branch
from
136dc1c to
2fd4846
Compare
jessegrabowski
approved these changes
Nov 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7575 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 106 106
Lines 17672 17673 +1
=======================================
+ Hits 16405 16407 +2
+ Misses 1267 1266 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://pymc--7575.org.readthedocs.build/en/7575/