Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential scale default to 1.0 #7604

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Dec 4, 2024


📚 Documentation preview 📚: https://pymc--7604.org.readthedocs.build/en/7604/

@Armavica
Copy link
Member

Armavica commented Dec 4, 2024

Any opinion on putting both lam and scale behind the *, to force users to specify which one they want? I'm sure there must be silent parameterization errors because of that

@ricardoV94
Copy link
Member Author

Any opinion on putting both lam and scale behind the *, to force users to specify which one they want? I'm sure there must be silent parameterization errors because of that

That would be a major change, historically only lam existed and could be passed by argument only. There was also a discussion with Normal, and people didn't want to force them to be kwarg only

@ricardoV94 ricardoV94 force-pushed the default_exponential_scale branch from 44a86b5 to 394ebe4 Compare December 4, 2024 14:42
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (3f3aeb9) to head (6a45ef6).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7604   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files         106      106           
  Lines       17742    17742           
=======================================
  Hits        16474    16474           
  Misses       1268     1268           
Files with missing lines Coverage Δ
pymc/distributions/continuous.py 98.25% <100.00%> (ø)
pymc/step_methods/hmc/nuts.py 97.43% <ø> (ø)

@ricardoV94 ricardoV94 merged commit 955ac23 into pymc-devs:main Dec 5, 2024
23 checks passed
@ricardoV94 ricardoV94 deleted the default_exponential_scale branch December 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants