-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for pymc native samplers to resume sampling from ZarrTrace
#7687
Draft
lucianopaz
wants to merge
12
commits into
pymc-devs:main
Choose a base branch
from
lucianopaz:zarr_continue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZarrTrace
fonnesbeck
reviewed
Feb 21, 2025
vars=trace_vars, | ||
test_point=initial_point, | ||
) | ||
except TraceAlreadyInitialized: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just InitializedTrace
? Seems a little verbose!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancements
feature request
major
Include in major changes release notes section
request discussion
samplers
trace-backend
Traces and ArviZ stuff
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Big PR approaching! This finishes adding the ability of pymc native step methods to resume sampling from an existing trace (as long as it's a
ZarrTrace
!). This means that you can now continue tuning or sampling from a pre-existing sample run. For exampleAnother thing is that the
chunks_per_draw
fromZarrTrace
along with its persistent storage backends (likeZipStore
orDirectoryStore
) makes the sampling store the results and final sampling state periodically, so in case of a crash during sampling, you can use the existing store to load the trace usingZarrTrace.from_store
and then resume sampling from there.The only thing that I haven't tested for yet is to add an
Op
that makespm.sample
crash to see if I can reload the partial results from the store and resume sampling. @ricardoV94 gave me some pointers to that, but I won't be working on this for the rest of the month and I thought it best to open a draft PR to kick off any discussion you have or collect feedbackRelated Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7687.org.readthedocs.build/en/7687/