Merge functional #20
Merged
Merge functional #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get mcmc sampling to work
Add credits
ColCarroll
reviewed
Aug 6, 2018
| @@ -0,0 +1,2 @@ | |||
| [pycodestyle] | |||
| max-line-length = 120 | |||
There was a problem hiding this comment.
this file should be removed (pylint handles this check)
There was a problem hiding this comment.
i think its overriding the default of 79 characters
.pylintrc
Outdated
| @@ -323,7 +323,7 @@ ignore-on-opaque-inference=yes | |||
| # List of class names for which member attributes should not be checked (useful | |||
| # for classes with dynamically set attributes). This supports the use of | |||
| # qualified names. | |||
| ignored-classes=optparse.Values,thread._local,_thread._local | |||
| ignored-classes=optparse.Values,thread._local,_thread._local, Context | |||
There was a problem hiding this comment.
is Context still needed to be ignored?
.pylintrc
Outdated
| @@ -54,7 +54,7 @@ confidence= | |||
| # --enable=similarities". If you want to run only the classes checker, but have | |||
| # no Warning level messages displayed, use"--disable=all --enable=classes | |||
| # --disable=W" | |||
| disable=missing-docstring | |||
| disable=missing-docstring, C0103 | |||
There was a problem hiding this comment.
should use full name for C0103 (i think invalid-constant-name)
| - pytest -xv --cov=pymc4/ test/ | ||
| - python -m pylint pymc4/ | ||
| - python -m pytest -xv --cov=pymc4/ tests/ | ||
| - pycodestyle --show-source --show-pep8 pymc4/ tests/ |
There was a problem hiding this comment.
ah, hadn't noticed pycodestyle is still being run. is there a good reason for that and pylint? in my experience it is faster, but less comprehensive.
There was a problem hiding this comment.
@ferrine had added it. Any reasons?
There was a problem hiding this comment.
I believe pycodestyle is better for style checks and linter for spotting typos
Pull Request Test Coverage Report for Build 64
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.