Skip to content

Add transposed argument to pt.linalg.solve #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jessegrabowski opened this issue Feb 21, 2025 · 0 comments · Fixed by #1231
Closed

Add transposed argument to pt.linalg.solve #1229

jessegrabowski opened this issue Feb 21, 2025 · 0 comments · Fixed by #1231
Assignees
Labels

Comments

@jessegrabowski
Copy link
Member

Description

This is allowed by scipy.linalg.solve, so we might as well support it. It's already an allowed argument for pt.linalg.solve_trianguar, so it's weird that it's not allowed generally. It will also save a transpose Op in the gradients of solve, because we can do b_bar = solve(A, x_bar, transposed=True) instead of b_bar=solve(A.T, x_bar). I understand transpose is just a stride thing, but I'm a completionist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant