Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate the CI pipeline #5

Closed
michaelosthege opened this issue Nov 21, 2022 · 7 comments
Closed

Accelerate the CI pipeline #5

michaelosthege opened this issue Nov 21, 2022 · 7 comments

Comments

@michaelosthege
Copy link
Member

Right now the CI is taking ~1.5 h.

However, we can split up jobs in the job matrix to parallelize more, and also investigate whether we're unnecessarily running things multiple times (e.g. different Python versions).

Maybe the scripts/check_all_tests_are_covered.py from PyMC can be adapted to quickly diagnose redundacies?

@danhphan
Copy link
Member

Hi @michaelosthege, let me work on this one :) Thanks!

@ricardoV94
Copy link
Member

I think GitHub CI is running the tests marked as slow, one failed recently. That could explain why they take so long

@danhphan
Copy link
Member

Yes, good points, I will look into it in details this weekend. Sorry for the delay :)

@ricardoV94
Copy link
Member

The runslow seems to be on purpose:

python -m pytest -x -r A --verbose --runslow --cov=pytensor/ --cov-report=xml:coverage/coverage-${MATRIX_ID}.xml --no-cov-on-fail $PART

@danhphan
Copy link
Member

Yes, the --runslow is used to run pytest on tests with @pytest.mark.slow decorator. All these slow tests are currently run on both python version 3.7 and 3.9. Running these slow tests on only one python version (3.9) should reduce CI running time.

I'm also looking into detail to see how to break these tests into smaller parts similar to PyMC workflows tests.yml

@danhphan
Copy link
Member

It seems that most slow tests are from tests/tensor/test_math.py and tests/tensor/test_basic.py, so I'm going to separate these two test files.

Screenshot from 2022-12-18 19-04-34

@ricardoV94
Copy link
Member

Closed via #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants