-
Notifications
You must be signed in to change notification settings - Fork 132
Support RandomVariable graphs with scalar shape parameters in JAX backend #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff899b1
to
9b9bcba
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
- Coverage 82.13% 82.12% -0.02%
==========================================
Files 211 211
Lines 49738 49751 +13
Branches 8816 8817 +1
==========================================
+ Hits 40852 40857 +5
- Misses 6710 6714 +4
- Partials 2176 2180 +4
🚀 New features to boost your workflow:
|
This solves pymc-devs/pymc#7348 |
9b9bcba
to
1e5c487
Compare
lucianopaz
approved these changes
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are just 3 minor changes that I requested before merging.
1e5c487
to
70e3929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it possible to do forward sampling in more PyMC models that use dims to define variables shapes
These was already a special rewrite to replace make_vector, expand_dims in the shape of RVs, but without handling these inputs from the outside it wouldn't achieve much for PyTensor users:
pytensor/pytensor/tensor/random/rewriting/jax.py
Lines 38 to 77 in e88117e
📚 Documentation preview 📚: https://pytensor--1029.org.readthedocs.build/en/1029/