Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small perf improvements #1128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ch0ronomato
Copy link
Contributor

@Ch0ronomato Ch0ronomato commented Dec 15, 2024

Description

There was a warning about copying a tensor, this change removes that. In addition, until we decide to keep torch autograd going around, I disabled it here to free up a bit of memory during the runtime. This brought back about 80us back from the mean time in the best case.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1128.org.readthedocs.build/en/1128/

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.10%. Comparing base (231a977) to head (8a3bf6a).

Files with missing lines Patch % Lines
pytensor/link/pytorch/dispatch/basic.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1128   +/-   ##
=======================================
  Coverage   82.10%   82.10%           
=======================================
  Files         185      185           
  Lines       48130    48133    +3     
  Branches     8669     8669           
=======================================
+ Hits        39519    39522    +3     
  Misses       6444     6444           
  Partials     2167     2167           
Files with missing lines Coverage Δ
pytensor/link/pytorch/linker.py 100.00% <100.00%> (ø)
pytensor/link/pytorch/dispatch/basic.py 94.49% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant