Skip to content

Make tests compatible with newer version of JAX #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Make tests compatible with newer version of JAX #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions tests/link/jax/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@ def compare_jax_and_py(

if must_be_device_array:
if isinstance(jax_res, list):
assert all(
isinstance(res, jax.interpreters.xla.DeviceArray) for res in jax_res
)
assert all(isinstance(res, jax.Array) for res in jax_res)
else:
assert isinstance(jax_res, jax.interpreters.xla.DeviceArray)

Expand Down Expand Up @@ -146,13 +144,13 @@ def test_shared():
pytensor_jax_fn = function([], a, mode="JAX")
jax_res = pytensor_jax_fn()

assert isinstance(jax_res, jax.interpreters.xla.DeviceArray)
assert isinstance(jax_res, jax.Array)
np.testing.assert_allclose(jax_res, a.get_value())

pytensor_jax_fn = function([], a * 2, mode="JAX")
jax_res = pytensor_jax_fn()

assert isinstance(jax_res, jax.interpreters.xla.DeviceArray)
assert isinstance(jax_res, jax.Array)
np.testing.assert_allclose(jax_res, a.get_value() * 2)

# Changed the shared value and make sure that the JAX-compiled
Expand All @@ -161,7 +159,7 @@ def test_shared():
a.set_value(new_a_value)

jax_res = pytensor_jax_fn()
assert isinstance(jax_res, jax.interpreters.xla.DeviceArray)
assert isinstance(jax_res, jax.Array)
np.testing.assert_allclose(jax_res, new_a_value * 2)


Expand Down