Fix bug in local_blockwise_advanced_inc_subtensor #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the local_blockwise_advanced_inc_subtensor functionality and extends test coverage to handle cases with both batched and unbatched core_y.
- Updated the test for local_blockwise_advanced_inc_subtensor with a new parameter (core_y_implicitly_batched) and random integer generation for improved variation.
- Modified the subtensor rewriting function to automatically apply expand_dims on y when necessary and adjusted symbolic index extraction.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/tensor/rewriting/test_subtensor.py | Extended test scenarios to cover both implicit batching and non-batching for core_y, refactoring expected behavior using a unified inplace function. |
| pytensor/tensor/rewriting/subtensor.py | Fixed bug in handling implicit dimensions by introducing expand_dims for y, and updated the extraction of symbolic indices accordingly. |
| symbolic_idxs = x[tuple(new_idxs)].owner.inputs[1:] | ||
| x_view = x[tuple(new_idxs)] | ||
|
|
||
| # We need to introduce any implicit expand_dims on core dimension of y |
There was a problem hiding this comment.
[nitpick] Consider expanding the comment to clarify why x_view is obtained and used for reassigning symbolic_idxs. This additional context would improve code maintainability.
Copilot uses AI. Check for mistakes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1405 +/- ##
=======================================
Coverage 82.10% 82.10%
=======================================
Files 208 208
Lines 49576 49581 +5
Branches 8791 8792 +1
=======================================
+ Hits 40704 40709 +5
Misses 6699 6699
Partials 2173 2173
🚀 New features to boost your workflow:
|
jessegrabowski
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up when trying to vectorize statespace models
📚 Documentation preview 📚: https://pytensor--1405.org.readthedocs.build/en/1405/