Respect check_finite in LU decomposition rewrites #1417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a test failing in PyMC that uses
check_finite=False
explicitly to test other stuff behaves correctly with NANs...It's still a shame that scipy/we default to
check_finite=False
, wonder if there is a way to test once at runtime whether the involved lapack functions do crash/not-terminate with nan/infs...📚 Documentation preview 📚: https://pytensor--1417.org.readthedocs.build/en/1417/