Skip to content

Respect check_finite in LU decomposition rewrites #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 23, 2025

There is a test failing in PyMC that uses check_finite=False explicitly to test other stuff behaves correctly with NANs...

It's still a shame that scipy/we default to check_finite=False, wonder if there is a way to test once at runtime whether the involved lapack functions do crash/not-terminate with nan/infs...


📚 Documentation preview 📚: https://pytensor--1417.org.readthedocs.build/en/1417/

@ricardoV94 ricardoV94 added bug Something isn't working graph rewriting linalg Linear algebra labels May 23, 2025
@ricardoV94 ricardoV94 requested a review from jessegrabowski May 23, 2025 09:53
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.10%. Comparing base (261aaf3) to head (2026641).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/tensor/_linalg/solve/rewriting.py 72.72% 0 Missing and 3 partials ⚠️

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
- Coverage   82.11%   82.10%   -0.01%     
==========================================
  Files         211      211              
  Lines       49686    49690       +4     
  Branches     8813     8815       +2     
==========================================
+ Hits        40798    40800       +2     
  Misses       6710     6710              
- Partials     2178     2180       +2     
Files with missing lines Coverage Δ
pytensor/tensor/type.py 94.61% <100.00%> (ø)
pytensor/tensor/_linalg/solve/rewriting.py 92.45% <72.72%> (-1.67%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 merged commit 148477c into pymc-devs:main May 23, 2025
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working graph rewriting linalg Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants