Skip to content

Raise NotImplementedError when trying to convert MaskedArrays #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Mar 29, 2023

Closes #258

Feature request issue #259

@ricardoV94 ricardoV94 added the bug Something isn't working label Mar 29, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #260 (3bbc1f7) into main (cbef7d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files         170      170           
  Lines       45394    45398    +4     
  Branches    11088    11090    +2     
=======================================
+ Hits        36512    36516    +4     
  Misses       6654     6654           
  Partials     2228     2228           
Impacted Files Coverage Δ
pytensor/scalar/basic.py 79.78% <100.00%> (+0.01%) ⬆️
pytensor/tensor/sharedvar.py 83.33% <100.00%> (+0.72%) ⬆️

@michaelosthege michaelosthege merged commit 33deba8 into pymc-devs:main Mar 30, 2023
@ricardoV94 ricardoV94 changed the title Raise NotImplementedError when trying to convert MaskedArrays Raise NotImplementedError when trying to convert MaskedArrays Apr 7, 2023
@ricardoV94 ricardoV94 deleted the raise_for_masked_arrays branch May 25, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: pytensor.shared does not respect masked missing values
3 participants