Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import CompileError from setuptools not distutils #277

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Apr 17, 2023

In combination wtih python/typeshed#10057, closes #240.

Motivation for these changes

Fix failing CI

Implementation details

Update deprecated import

Checklist

Major / Breaking Changes

  • ...

New features

  • ...

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • Partial preparation for PEP 632, deprecation of distutils

This is to ensure that we get python/typeshed#10057 so
that #277 is resolved.
@maresb
Copy link
Contributor Author

maresb commented Apr 17, 2023

Got it!!! Now it's just a matter of the standard tests completing.

@codecov-commenter
Copy link

Codecov Report

Merging #277 (0cc24b6) into main (acfa749) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   80.47%   80.47%           
=======================================
  Files         171      171           
  Lines       45433    45433           
  Branches    11094    11094           
=======================================
  Hits        36560    36560           
  Misses       6640     6640           
  Partials     2233     2233           
Impacted Files Coverage Δ
pytensor/link/c/exceptions.py 80.00% <100.00%> (ø)

@ricardoV94
Copy link
Member

Looks good, can you revert c3bfe66

in order to close the original issue?

@ricardoV94 ricardoV94 merged commit 5e04917 into main Apr 18, 2023
@maresb maresb deleted the maresb-patch-1 branch April 18, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run mypy job with Python 3.11 once it is supported
3 participants