Fix RandomVariable static type shape bug #475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug showed up in pymc-devs/pymc#6947
Which would later lead to a rewrite error during compilation.
It was caused by the presence of
np.int
in the static shape of Join, (and correspondingnp.bool
in the broadcastable), which would then be overlooked by an explicit checkbroadcastable is False
in theRandomVariable.infer_shape
.