Skip to content

Fix too restrictive type assert #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jul 4, 2024

Introduced in f9dfe70

Causing PyMC CI to fail in pymc-devs/pymc#7400

https://github.com/pymc-devs/pymc/actions/runs/9790920723/job/27033597109?pr=7400#step:7:3094

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 added the bug Something isn't working label Jul 4, 2024
@ricardoV94 ricardoV94 requested a review from michaelosthege July 4, 2024 09:20
@ricardoV94 ricardoV94 changed the title Fix wrong type assert Fix too restrictive type assert Jul 4, 2024
@ricardoV94 ricardoV94 requested a review from twiecki July 4, 2024 09:22
@ricardoV94 ricardoV94 merged commit afc1a6c into pymc-devs:main Jul 4, 2024
53 checks passed
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (df769f6) to head (6ba70b8).
Report is 117 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #880   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files         169      169           
  Lines       46845    46845           
  Branches    11485    11485           
=======================================
  Hits        37959    37959           
+ Misses       6679     6677    -2     
- Partials     2207     2209    +2     
Files with missing lines Coverage Δ
pytensor/tensor/subtensor.py 89.20% <100.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants