Merge consecutive reduces #888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does some cleanup and extends reduction rewrites. Check each commit for the individual changes. Summary:
tracks
machinery already handles subclasses automatically. It did not always do it, which is probably why the list existedStop defining Min as negative of Max, to later undo it and actually use Min. I think this is just some historical accident?Reverted, too many things depend on this for me to tackle now: Reconsider min implementation as negative of max #904expand_dims
or any other reason. It shouldn't matter, as long as we can squeeze it out.Checklist
Type of change