Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ScalarLoop in torch backend #958

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Do iteration instead of vmap for elemwise

c467a34
Select commit
Loading
Failed to load commit list.
Open

Implement ScalarLoop in torch backend #958

Do iteration instead of vmap for elemwise
c467a34
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 27, 2024 in 0s

81.91% (+0.01%) compared to a377c22

View this Pull Request on Codecov

81.91% (+0.01%) compared to a377c22

Details

Codecov Report

Attention: Patch coverage is 60.78431% with 20 lines in your changes missing coverage. Please review.

Project coverage is 81.91%. Comparing base (a377c22) to head (c467a34).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/link/pytorch/dispatch/elemwise.py 36.36% 14 Missing ⚠️
pytensor/link/pytorch/dispatch/scalar.py 84.00% 2 Missing and 2 partials ⚠️
pytensor/link/pytorch/linker.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   81.90%   81.91%   +0.01%     
==========================================
  Files         182      182              
  Lines       47879    47936      +57     
  Branches     8617     8627      +10     
==========================================
+ Hits        39214    39269      +55     
- Misses       6492     6496       +4     
+ Partials     2173     2171       -2     
Files with missing lines Coverage Δ
pytensor/link/pytorch/linker.py 91.66% <50.00%> (-8.34%) ⬇️
pytensor/link/pytorch/dispatch/scalar.py 72.91% <84.00%> (+12.04%) ⬆️
pytensor/link/pytorch/dispatch/elemwise.py 61.73% <36.36%> (-7.02%) ⬇️

... and 5 files with indirect coverage changes