Skip to content

Convert all instances of obs_indx to obs_ind #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drbenvincent opened this issue Apr 21, 2025 · 0 comments · Fixed by #462
Closed

Convert all instances of obs_indx to obs_ind #459

drbenvincent opened this issue Apr 21, 2025 · 0 comments · Fixed by #462
Assignees
@drbenvincent
Labels
bug Something isn't working refactor Refactor, clean up, or improvement with no visible changes to the user

Comments

@drbenvincent
Copy link
Collaborator

This is not giving rise to any known bugs, but I've seen that the coord for rows (observations) is almost always called obs_ind, there are some cases where it's labelled as obs_indx. So we need to convert all to obs_ind to be consistent.
@drbenvincent drbenvincent added bug Something isn't working refactor Refactor, clean up, or improvement with no visible changes to the user labels Apr 21, 2025
@drbenvincent drbenvincent self-assigned this Apr 21, 2025
drbenvincent added a commit that referenced this issue Apr 21, 2025
@drbenvincent
obs_indx -> obs_ind (see #459)
98127fd
This was referenced Apr 21, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drbenvincent drbenvincent

Labels
bug Something isn't working refactor Refactor, clean up, or improvement with no visible changes to the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bug: obs_indx -> obs_ind and improve PyMCModel._data_setter pymc-labs/CausalPy
1 participant
@drbenvincent