setup.py
is dead, long live pyproject.toml
#156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105. This PR greatly simplifies things. We've moved to a more modern workflow where all the config stuff is contained in
pyproject.toml
.So I've been able to delete:
setup.py
.isort.cfg
manifest.in
requirements.txt
requirements-dev.txt
requirements-docs.txt
requirements-lint.txt
requirements-test.txt
The requirements are now in
pyproject.toml
. Devs can install by runningpip install causalpy[dev]
for example.Instructions to developers have been updated in
CONTRIBUTING.md
Tests pass locally and remotely.
I've been through a build, upload to pypi, install process and can confirm it's pip installable in a temp local environment.
Oh, and the dev environment now uses pymc>=5.0.0 🎉
PS. When I was testing, I uploaded to pypi with version 0.0.10a, thinking that is counted as a pre-release. But I think it's the case that anyone doing
pip install causalpy
will already be getting this version not yet merged intomain
.Remaining things
pyproject.toml
#155. If not, it will be easy if we use some auto version bump tool. Otherwise manual is fine for the moment.setup.cfg
remains now becauseflake8
doesn't play ball withpyproject.toml
. There may be something we can do about this in the future.