Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to readthedocs and add favicon #245

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

jpreszler
Copy link
Contributor

This resolves issue #237 .

I'm using the same image for the favicon, which looks ok according to http://www.colinkeany.com/favicon-checker/, but in general I think the logo isn't the best on dark themed browsers, so it may be worth having a specialized favicon version of the logo that looks good at the small size in all themes.

Screenshot 2023-09-19 at 1 00 51 PM

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #245 (01e566d) into main (28d50b9) will not change coverage.
Report is 8 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files          19       19           
  Lines        1149     1149           
=======================================
  Hits          849      849           
  Misses        300      300           

@jpreszler
Copy link
Contributor Author

I took a stab at a specialized favicon that is a bit more distinctive in browser tabs (especially dark themed). I've added a white background, extracted the rocket and dag parts, and done some color and sharpness adjustments to help the contrast.

Screenshot 2023-09-21 at 9 45 46 AM

@jpreszler
Copy link
Contributor Author

@drbenvincent this is ready when you get a chance.

@drbenvincent
Copy link
Collaborator

Nice! Sorry for the delay - I've had some newborn parenting challenges. I'll merge this and see how things go. We can always iterate on the logo or light/dark theme if needed, but this looks good already.

@drbenvincent drbenvincent added the documentation Improvements or additions to documentation label Oct 17, 2023
@drbenvincent drbenvincent changed the title fix logo path and add favicon option Add logo to readthedocs and add favicon Oct 17, 2023
@drbenvincent drbenvincent merged commit 19b4b6d into pymc-labs:main Oct 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants