Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing images on PyPI page #270

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix missing images on PyPI page #270

merged 1 commit into from
Nov 15, 2023

Conversation

krz
Copy link
Contributor

@krz krz commented Nov 11, 2023

I replaced the image links in the README.md with their absolute paths. This should fix issue #261 .
The codecov link is unchanged and will still not be displayed properly on PyPi (probably because of the required token id).

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3c542d) 75.91% compared to head (33dea09) 75.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   75.91%   75.91%           
=======================================
  Files          20       20           
  Lines        1308     1308           
=======================================
  Hits          993      993           
  Misses        315      315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twiecki twiecki merged commit 2169bf0 into pymc-labs:main Nov 15, 2023
11 checks passed
@twiecki
Copy link
Contributor

twiecki commented Nov 15, 2023

Thanks @krz!

@drbenvincent drbenvincent added the documentation Improvements or additions to documentation label Nov 15, 2023
@drbenvincent drbenvincent changed the title add absolute paths to images in README to fix PiPy description Fix missing images on PyPI page Nov 15, 2023
jsakv pushed a commit to jsakv/CausalPy that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants