Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #288: remove deprecated 'model' property in tests. #291

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

anevolbap
Copy link
Contributor

@anevolbap anevolbap commented Feb 12, 2024

Closes issue #288.

Removes the FutureWarning in tests caused by a deprecated property:

FutureWarning: Model.model property is deprecated. Just use Model.
    warnings.warn("Model.model property is deprecated. Just use Model.", FutureWarning)

@anevolbap anevolbap changed the title Fix: remove deprecated 'model' property in tests. Fix #288: remove deprecated 'model' property in tests. Feb 12, 2024
@drbenvincent drbenvincent added the bug Something isn't working label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.50%. Comparing base (67d9e0e) to head (60e537c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   76.50%   76.50%           
=======================================
  Files          20       20           
  Lines        1345     1345           
=======================================
  Hits         1029     1029           
  Misses        316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drbenvincent
Copy link
Collaborator

Thanks!

@drbenvincent drbenvincent merged commit d5e493c into pymc-labs:main Mar 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants