Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #299: Rounding issue for DiD results. #302

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

anevolbap
Copy link
Contributor

Closes #299 .

  • Rounding round_num was applied to a string. The method itself handles the rounding.
  • Tests are already done here.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.10%. Comparing base (2223fa0) to head (42018ca).

Files Patch % Lines
causalpy/pymc_experiments.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   77.06%   77.10%   +0.03%     
==========================================
  Files          21       21              
  Lines        1378     1380       +2     
==========================================
+ Hits         1062     1064       +2     
  Misses        316      316              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anevolbap anevolbap marked this pull request as draft March 5, 2024 03:17
@anevolbap anevolbap marked this pull request as ready for review March 5, 2024 03:52
@drbenvincent drbenvincent merged commit 3bb81a7 into pymc-labs:main Mar 5, 2024
10 checks passed
@drbenvincent drbenvincent added the bug Something isn't working label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UFuncTypeError when calling summary method
2 participants