Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #287 Update Makefile #309

Merged
merged 4 commits into from
Mar 24, 2024
Merged

Conversation

anevolbap
Copy link
Contributor

@anevolbap anevolbap commented Mar 16, 2024

Closes #287.

To test it, I created a new virtual environment (with pyenv) from scratch and ran the installation commands and the Makefile commands as well.

This PR seems to overlap a bit with this one.

@anevolbap anevolbap changed the title Fix #287 Update makefile Fix #287 Update Makefile Mar 16, 2024
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (3bb81a7) to head (13106b1).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          21       21           
  Lines        1380     1380           
=======================================
  Hits         1064     1064           
  Misses        316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drbenvincent drbenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. This addresses #287. Thanks for pointing out that this overlaps with #304 - that PR got a bit unwieldy because it simultaneously tried to make the changes to the makefile and move to a conda only install. I think I'll merge this PR now because it focusses #287 solely.

@drbenvincent drbenvincent merged commit 5a74c04 into pymc-labs:main Mar 24, 2024
10 checks passed
@drbenvincent drbenvincent added the devops DevOps related label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the pip install lines in Makefile and add the --no-deps flag for the local install
2 participants