Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound MyST NB to fix the compressed images. #332

Merged
merged 1 commit into from
May 6, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz requested a review from drbenvincent May 6, 2024 15:08
@juanitorduz juanitorduz self-assigned this May 6, 2024
@juanitorduz juanitorduz added documentation Improvements or additions to documentation devops DevOps related no releasenotes Skipped in automatic release note generation labels May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (dbaa17b) to head (df17a1e).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   77.10%   77.27%   +0.17%     
==========================================
  Files          21       21              
  Lines        1380     1395      +15     
==========================================
+ Hits         1064     1078      +14     
- Misses        316      317       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drbenvincent drbenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :)

Just wondering if there's a more future proof solution than pinning myst-nb<=1.0.0? Currently it's on 1.1.0 and we might want to use new versions at some point.

@juanitorduz
Copy link
Collaborator Author

I don't think any fix will come before their next release so this is temporal. We can also wait 😄

@drbenvincent
Copy link
Collaborator

Happy to pull the trigger now, because readthedocs is currently set up to render the latest on main. So the page is already available, with the poor images.

@drbenvincent drbenvincent merged commit 3dc2ffe into main May 6, 2024
7 checks passed
@drbenvincent drbenvincent deleted the bound_myst_nb_version branch May 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps related documentation Improvements or additions to documentation no releasenotes Skipped in automatic release note generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants