Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up ruff pre-commit checks to operate on notebooks #352

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

drbenvincent
Copy link
Collaborator

@drbenvincent drbenvincent added the devops DevOps related label Jun 14, 2024
@drbenvincent drbenvincent requested a review from NathanielF June 14, 2024 10:28
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.98%. Comparing base (1648681) to head (c9b2a34).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #352   +/-   ##
=======================================
  Coverage   79.98%   79.98%           
=======================================
  Files          21       21           
  Lines        1634     1634           
=======================================
  Hits         1307     1307           
  Misses        327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drbenvincent drbenvincent added this to the 0.3.1 milestone Jun 14, 2024
Copy link
Contributor

@NathanielF NathanielF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@drbenvincent drbenvincent merged commit e092650 into main Jun 14, 2024
8 checks passed
@drbenvincent drbenvincent deleted the ruff branch June 14, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check pre-commit ruff formatting for notebooks is set up correctly
2 participants