Use ModelBuilder for multidimensional MMM #1447
Merged
+219
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
docs
wd60622
changed the base branch from
main
to
cetagostini/multidimensionalmediamix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cetagostini/multidimensionalmediamix #1447 +/- ##
=========================================================================
- Coverage 88.90% 49.96% -38.95%
=========================================================================
Files 51 51
Lines 5797 5828 +31
=========================================================================
- Hits 5154 2912 -2242
- Misses 643 2916 +2273 ☔ View full report in Codecov by Sentry. |
wd60622
merged commit 1fe0c7f
into
cetagostini/multidimensionalmediamix
3 of 4 checks passed
juanitorduz
added a commit
that referenced
this pull request
Feb 6, 2025
* example notebook and code * pre-commit * Initial approximation on HSGP class * WIP. * WIP (Main model working) * Properly adding scales into model graph * Working in API and plots * Add docstring * rename the module * change the import * Pushing changes in call * plot property instead of mixin * initial set of tests * pre-commit * New test * Use ModelBuilder for multidimensional MMM (#1447) * inherit from ModelBuilder * remove FutureWarnings * fix conflicts * run ruff * support case with seasonality * changes to allow accepting y as Series * mock all fitting in tests * Wip * restore test mini fit. * wip * mini pre-commit * Current changes with Will * add the forgotten set_idata_attrs call * Delete guassian basis * add a module warning * remove the mutable which causes warning * move to a dev folder * pull out into module * change the date * change the name of the model * typehint the plot accessory * add the typehint * use the conftest mocking * change the import --------- Co-authored-by: Juan Orduz <juanitorduz@gmail.com> Co-authored-by: Will Dean <wd60622@gmail.com> Co-authored-by: Will Dean <57733339+wd60622@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inherit from ModelBuilder for new MMM
Related Issue
Checklist
pre-commit.ci autofixto auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1447.org.readthedocs.build/en/1447/