-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ModelBuilder for multidimensional MMM #1447
Use ModelBuilder for multidimensional MMM #1447
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cetagostini/multidimensionalmediamix #1447 +/- ##
=========================================================================
- Coverage 88.90% 49.96% -38.95%
=========================================================================
Files 51 51
Lines 5797 5828 +31
=========================================================================
- Hits 5154 2912 -2242
- Misses 643 2916 +2273 ☔ View full report in Codecov by Sentry. |
…ilder
…ilder
1fe0c7f
into
cetagostini/multidimensionalmediamix
* example notebook and code * pre-commit * Initial approximation on HSGP class * WIP. * WIP (Main model working) * Properly adding scales into model graph * Working in API and plots * Add docstring * rename the module * change the import * Pushing changes in call * plot property instead of mixin * initial set of tests * pre-commit * New test * Use ModelBuilder for multidimensional MMM (#1447) * inherit from ModelBuilder * remove FutureWarnings * fix conflicts * run ruff * support case with seasonality * changes to allow accepting y as Series * mock all fitting in tests * Wip * restore test mini fit. * wip * mini pre-commit * Current changes with Will * add the forgotten set_idata_attrs call * Delete guassian basis * add a module warning * remove the mutable which causes warning * move to a dev folder * pull out into module * change the date * change the name of the model * typehint the plot accessory * add the typehint * use the conftest mocking * change the import --------- Co-authored-by: Juan Orduz <juanitorduz@gmail.com> Co-authored-by: Will Dean <wd60622@gmail.com> Co-authored-by: Will Dean <57733339+wd60622@users.noreply.github.com>
Description
Inherit from ModelBuilder for new MMM
Related Issue
Checklist
pre-commit.ci autofix
to auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1447.org.readthedocs.build/en/1447/