Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ModelBuilder for multidimensional MMM #1447

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jan 31, 2025

Description

Inherit from ModelBuilder for new MMM

Related Issue

  • Closes #
  • Related to #

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1447.org.readthedocs.build/en/1447/

Sorry, something went wrong.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation MMM tests labels Jan 31, 2025
@wd60622 wd60622 changed the base branch from main to cetagostini/multidimensionalmediamix January 31, 2025 13:01
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 25.45455% with 41 lines in your changes missing coverage. Please review.

Project coverage is 49.96%. Comparing base (a7b8a07) to head (e70b526).
Report is 3 commits behind head on cetagostini/multidimensionalmediamix.

Files with missing lines Patch % Lines
pymc_marketing/mmm/multidimensional.py 25.45% 41 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a7b8a07) and HEAD (e70b526). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (a7b8a07) HEAD (e70b526)
11 3
Additional details and impacted files
@@                            Coverage Diff                            @@
##           cetagostini/multidimensionalmediamix    #1447       +/-   ##
=========================================================================
- Coverage                                 88.90%   49.96%   -38.95%     
=========================================================================
  Files                                        51       51               
  Lines                                      5797     5828       +31     
=========================================================================
- Hits                                       5154     2912     -2242     
- Misses                                      643     2916     +2273     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622 wd60622 requested a review from cetagostini January 31, 2025 13:08
wd60622 and others added 7 commits January 31, 2025 14:10
@wd60622 wd60622 merged commit 1fe0c7f into cetagostini/multidimensionalmediamix Jan 31, 2025
3 of 4 checks passed
@wd60622 wd60622 deleted the use-model-builder branch January 31, 2025 14:09
juanitorduz added a commit that referenced this pull request Feb 6, 2025
* example notebook and code

* pre-commit

* Initial approximation on HSGP class

* WIP.

* WIP (Main model working)

* Properly adding scales into model graph

* Working in API and plots

* Add docstring

* rename the module

* change the import

* Pushing changes in call

* plot property instead of mixin

* initial set of tests

* pre-commit

* New test

* Use ModelBuilder for multidimensional MMM (#1447)

* inherit from ModelBuilder

* remove FutureWarnings

* fix conflicts

* run ruff

* support case with seasonality

* changes to allow accepting y as Series

* mock all fitting in tests

* Wip

* restore test mini fit.

* wip

* mini pre-commit

* Current changes with Will

* add the forgotten set_idata_attrs call

* Delete guassian basis

* add a module warning

* remove the mutable which causes warning

* move to a dev folder

* pull out into module

* change the date

* change the name of the model

* typehint the plot accessory

* add the typehint

* use the conftest mocking

* change the import

---------

Co-authored-by: Juan Orduz <juanitorduz@gmail.com>
Co-authored-by: Will Dean <wd60622@gmail.com>
Co-authored-by: Will Dean <57733339+wd60622@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant