Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes documentation on mmm control variable scaling - Issue #1469 #1499

Conversation

zach-brown-18
Copy link
Contributor

@zach-brown-18 zach-brown-18 commented Feb 13, 2025

Corrected mmm documentation to show that control variables are not automatically scaled.

Description

Corrected the notes in /docs/source/notebooks/mmm/mmm_example.ipynb so that they now state that control variables are not automatically scaled.

Related Issue

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1499.org.readthedocs.build/en/1499/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation MMM labels Feb 13, 2025
@zach-brown-18
Copy link
Contributor Author

I am new to open source and thought I'd take a stab at one of the simpler documentation updates. Hope it helps!

@wd60622
Copy link
Contributor

wd60622 commented Feb 14, 2025

Hi Zach, tremendous help. Thanks!

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wd60622 wd60622 merged commit 6b5279f into pymc-labs:main Feb 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing documentation on scaling of control variables
2 participants