Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MediaTransformation dims in save and load #1503

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Feb 14, 2025

Description

Was forgotten about. Now will be used

Related Issue

  • Closes #
  • Related to #

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1503.org.readthedocs.build/en/1503/

@wd60622 wd60622 linked an issue Feb 14, 2025 that may be closed by this pull request
@wd60622 wd60622 requested a review from juanitorduz February 14, 2025 12:44
@wd60622 wd60622 added the bug Something isn't working label Feb 14, 2025
@github-actions github-actions bot added the media transforms Related to adstock, saturation, and media transformations label Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (6ca3a30) to head (2a64d16).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1503      +/-   ##
==========================================
+ Coverage   92.59%   92.63%   +0.03%     
==========================================
  Files          52       52              
  Lines        6051     6053       +2     
==========================================
+ Hits         5603     5607       +4     
+ Misses        448      446       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622 wd60622 requested a review from cetagostini February 14, 2025 13:27
@juanitorduz
Copy link
Collaborator

@wd60622 can you please resolve the conflict and then feel free to merge :)

@wd60622
Copy link
Contributor Author

wd60622 commented Feb 14, 2025

pre-commit.ci autofix

@wd60622 wd60622 merged commit 1b8eeb5 into main Feb 14, 2025
20 of 21 checks passed
@wd60622 wd60622 deleted the 1295-dims-missing-from-mediatransfromto_dict branch February 14, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working media transforms Related to adstock, saturation, and media transformations MMM tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dims missing from MediaTransfrom.to_dict
2 participants