Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff RUF rules #636

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Add ruff RUF rules #636

merged 3 commits into from
Apr 16, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Apr 16, 2024 •
edited by github-actions bot
Loading

Add RUF rules as the PyMC configuration.

📚 Documentation preview 📚: https://pymc-marketing--636.org.readthedocs.build/en/636/

@juanitorduz juanitorduz self-assigned this Apr 16, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.62%. Comparing base (2be2f63) to head (f5c118e).

Files Patch % Lines
pymc_marketing/mmm/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   91.18%   91.62%   +0.43%     
==========================================
  Files          22       22              
  Lines        2280     2280              
==========================================
+ Hits         2079     2089      +10     
+ Misses        201      191      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz requested a review from ulfaslak April 16, 2024 13:03
wd60622
wd60622 reviewed Apr 16, 2024
View reviewed changes
pymc_marketing/mmm/base.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
wd60622
wd60622 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@juanitorduz juanitorduz merged commit 582d2ed into main Apr 16, 2024
9 of 10 checks passed
@juanitorduz juanitorduz deleted the add_ruff_rules branch April 16, 2024 16:55
twiecki pushed a commit that referenced this pull request Sep 10, 2024
@juanitorduz @twiecki
Add ruff RUF rules (#636)
354cd4a
twiecki pushed a commit that referenced this pull request Sep 10, 2024
@juanitorduz @twiecki
Add ruff RUF rules (#636)
29beed9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cetagostini cetagostini cetagostini approved these changes

@wd60622 wd60622 wd60622 approved these changes

@ricardoV94 ricardoV94 Awaiting requested review from ricardoV94

@twiecki twiecki Awaiting requested review from twiecki

@ulfaslak ulfaslak Awaiting requested review from ulfaslak

Assignees

@juanitorduz juanitorduz

Labels
maintenance no releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanitorduz @ricardoV94 @wd60622 @cetagostini