Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #80

Merged
merged 3 commits into from
May 16, 2024
Merged

Improve documentation #80

merged 3 commits into from
May 16, 2024

Conversation

BenediktBurger
Copy link
Member

Address some issues from #40

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (5235b4d) to head (9ebb869).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          36       36           
  Lines        2903     2903           
  Branches      355      355           
=======================================
  Hits         2543     2543           
  Misses        300      300           
  Partials       60       60           
Flag Coverage Δ
unittests 87.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger BenediktBurger force-pushed the improve-documentation branch from 92520de to 8d0719c Compare May 14, 2024 18:45
@BenediktBurger BenediktBurger mentioned this pull request May 15, 2024
5 tasks
@BenediktBurger
Copy link
Member Author

I added (mermaid) flow charts to the GETTING_STARTED.md to make it easier to understand, how the different components work together.

The diagram information is only additional to the text, so if it does not render, it is only a small part of source code to skip.
The readme links to the GETTING_STARTED.md on github, and github can render mermaid, which should work well.

What do you think, @bilderbuchi , @bklebel ?

@bilderbuchi
Copy link
Member

I think it's no problem to add mermaid blocks.

@BenediktBurger BenediktBurger marked this pull request as ready for review May 16, 2024 11:04
@BenediktBurger BenediktBurger merged commit 96f5e98 into main May 16, 2024
20 checks passed
@BenediktBurger BenediktBurger deleted the improve-documentation branch May 16, 2024 11:05
@bklebel
Copy link
Collaborator

bklebel commented May 16, 2024

looks quite nice! :)

@BenediktBurger
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants