Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 313 #98

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Add support for Python 313 #98

merged 3 commits into from
Oct 29, 2024

Conversation

BenediktBurger
Copy link
Member

No description provided.

@BenediktBurger
Copy link
Member Author

BenediktBurger commented Oct 15, 2024

These ServerErrors are probably due do some changes in openrpc. Python 313 uses openrpc-10.3.2 (as it is not yet cached, contrary to the other ones)

EDIT: 3.12 works with openrpc-10.3.2

EDIT2: It seems, that openrpc itself does not work with python 3.13, see upstream issue https://gitlab.com/mburkard/openrpc/-/issues/9

@BenediktBurger
Copy link
Member Author

Note that it is still possible to use PyLECO with the integrated fallback version, just uninstall openrpc.

@BenediktBurger BenediktBurger added bug Something isn't working dependency Related to external libraries. labels Oct 16, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (30b307b) to head (0440eed).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   89.62%   89.52%   -0.11%     
==========================================
  Files          38       38              
  Lines        2988     2988              
  Branches      373      312      -61     
==========================================
- Hits         2678     2675       -3     
- Misses        259      262       +3     
  Partials       51       51              
Flag Coverage Δ
unittests 89.52% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger BenediktBurger force-pushed the py313 branch 4 times, most recently from 6ad12a7 to f623eb3 Compare October 29, 2024 10:14
@BenediktBurger BenediktBurger merged commit 45f7e18 into main Oct 29, 2024
22 of 23 checks passed
@BenediktBurger BenediktBurger deleted the py313 branch October 29, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependency Related to external libraries.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant