-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AniDB anime-titles.xml not cached #4820
Comments
That strange. I do know that the location where the two files are cached is not ideal. Could you check if the data modified is changing each time you edit a show? It should stay the same for one day. And the file should not be updated more then once a day. Also which os are you using? |
I can't verify at the moment. Since I'm currently banned the edit page won't even load. There's nothing interesting in the debug logs either. Is there any way to get more helpful debug messages? Currently it's not even mentioning AniDB when I edit a show. This is using the linuxserver.io docker image on RancherOS. |
Do you maybe only have the cache folder mounted in your container? So you get a new medusa application files each time you restart it? |
You should check out the lib/abda folder i mentioned. And check the modification dates on the files. |
I was able to verify using tcpdump that it indeed only tries to access the UDP API and that the xml file seems to be cached properly. I'm not sure what caused me to get banned but it definitely happened after doing what I described previously. Maybe it's triggering some flood protection in their UDP API. I've restarted the container a few times to verify and the file doesn't get removed. It should only get wiped if I re-created the container. |
Okay.. Well ill move the cached files to the medusa cache folder. Then you should never loose them. Also not when recreating the container. I have another pr ready where we will cache the anidb udp release names. That should also help. |
I was unbanned for a while and then hit the ban again trying to debug this. The only thing going on was medusa requesting fansub groups from the UDP API so that has got to be it. Here's the ban message from the logs:
|
Ill try to implement the caching next days. |
This should be fixed in the develop branch. Can you test it? |
Using latest develop I was able to verify that it now only sends 2 requests to the UDP API when adding a new show and never anything else, so that seems to be working. I was not able to get it to update any shows that were already added through various attempts. Perhaps doing a "Force Full Update" should also request the release groups again. |
Ill look into that |
Your new request is about invalidating the cache. We'll pick that up in next release. |
Describe the bug
It seems like the AniDB anime titles database gets downloaded every time a request is made to AnbiDB. This results in their servers automatically placing a ban if, for instance, you view the fansub group settings of too many different shows in rapid succession.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Additional context
AniDB's rules regarding anime-titles.xml.gz can be found at https://wiki.anidb.net/w/API#Anime_Titles and states that it should not be downloaded more than once per day.
The text was updated successfully, but these errors were encountered: