Feature/upgrade adba to medusa adba #4822
Conversation
* Removed release group code from editShow in handler.py. As we're using the apiv2 now. No need to get release groups twice from adba client.
|
Linking for discussion #2439 |
|
I'm a little lost on the ConfigParser thing. So I'd like to hear other opinions. |
Add package backports to /ext Add package configparser to /ext Update requirements.txt with configparser Add makedirs, for cache folder, to lib adba. These xml files conflict with one another. use cache/adba for adba lib. use cache/simpleanidb for simpleanidb lib.
p0psicles
added
Concluded
Needs review
Needs test (Python)
medusa/helpers/anidb.py
Outdated
| @@ -43,6 +41,8 @@ def anidb_logger(msg): | |||
| else: | |||
| return True | |||
| except Exception as error: | |||
| import traceback | |||
| print traceback.format_exc() | |||
Remove print
|
Reminder to myself to also update changelog |
ext/adba/__init__.py
Outdated
| resp = self.auth(self._username, self._password) | ||
| if resp.rescode not in ('500'): | ||
| if resp.rescode not in '500': |
There was a problem hiding this comment.
This should be !=. Didn't review, just noticed while skipping through.
* Cleaned up logging string templating.
…com/pymedusa/Medusa into feature/upgrade-adba-to-medusa-adba
…grade-adba-to-medusa-adba
sharkykh
added
Needs testing
|
You should push the latest change you made to |
|
Pff. Yeah but then i need to make another change. Like to have approvals before i do that. I wont forget |
* updated ext/readme.md
|
Okay should be done now |
requirements.txt
Outdated
| @@ -1,10 +1,13 @@ | |||
| # No setup.py, unable to install using pip | |||
| git+https://github.com/pymedusa/adba.git@119b9d30a30feb97bcea5e1dc742c82340300091#egg=adba | |||
There was a problem hiding this comment.
FYI, since the adba package has no setup.py, it can't be installed using pip, that's why I decided to comment it out and added a comment above.
There was a problem hiding this comment.
Ooh yeah didnt think of that
ext/readme.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| ## ext | |||
| Status | Package | Version / Commit | Usage | Notes | |||
| :------: | :-------: | :----------------: | :---- | :---- | |||
| :: | `adba` | pymedusa/[0e1657f](https://github.com/pymedusa/adba/tree/119b9d30a30feb97bcea5e1dc742c82340300091) | **`medusa`** | - | |||
There was a problem hiding this comment.
Change the link text (inside the brackets) to the 7 first characters of the commit SHA (119b9d3)
Goal of this PR:
But unfortunately it was not python 2 compatible, so I had to make some changes. From here we'll have to take another look at py3.
Fixes #4820
The Py23ConfigParser class should be removed. And we should go for another solution.
The issue is this:
The included ConfigParser with python 2.7 does not work using the dict syntax on python2. You can use python3 syntax in python2 using the back ported configparser module available on PyPy.So we could go with:
1. Add the backport configparser pypy version as a dependency in the adba lib.2. Add the backport configparser version to our /ext folder
3. Transform adba lib to use python2 configparser syntax.Libs: https://github.com/pymedusa/adba and https://github.com/pymedusa/simpleanidb have also been updated (develop branches)