-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Synology Downloadstation breaks integration #9366
Comments
Would appreciate if someone with this version of ds and Synology would do a PR |
Hello, Sorry, i would love to help but i'm not really a dev :( EDIT : |
I have no problem with Download Station and using torrents. |
No I am not using 'Black Hole" If it is random then most likely it has something to do with a timeout, is your Nas very busy? |
Maybe it is dependent on the torrent you try to add. |
That's a valid point @BenjV. As medusa can send the torrent as well as magnet url But maybe there are even some other subtle differences here. |
Performed some tests with different open providers and so far only been able to recreate the issue with eztv. |
I found a mention on the web that adding to DownloadStation according to the API documentation should be done with a post command but only works correct with a get command. I will build a test application to test this in the debugger, I post the results when if have something. |
@BenjV could you contact me on our discord. Have something to ask |
I have no Idea what your "discord" is. |
Still not able to reproduce the problem. @H85 |
@BenjV Not sure this will help but for me this happened 19/03 so i couldn't find exhaustive logs in the UI... Anyway i think this happened with the following shows :
Based on what i could retrieve :
|
Hmm does not help much. Did you change anything in your Nas concerning the username and/or password you are using for Medusa and forgot to change that in Medusa? EDIT: The file option is only to be used if you want to use a file located on the filesystem of the Nas, if it is a link (HTTP/FTP/magnet/ED2K) the uri option has to be used. I will look for the best way to fix this, along with some other minor issues. |
@BenjV I'm not checked the code, but actually the |
You are half correct. If you use the 'file" option in the DownLoad Station API then it expect a file on the local filesystem and not a link to something on the web. This could never have worked. This is an example what Medusa is sending to DownLoad Station when it does not find a magnetlink but a link to a .torrent file The var "file" should be filled with the path+filename of the torrent file. |
I have located the problem. @p0psicles |
I've reupdated to the latest version (3.8.16.-3566) and it's giving me the issue again.
|
@p0psicles In the "downloadstation.py" file you should add this on line 129
If there is a uri available (always the case) then the add_torrent_uri is used instead of the add_torrent_file This fix will solve the problem of the latest version of Download Station. |
@BenjV can you double check the branch I created? |
I made a copy of your change and installed it on my Medusa installation on my Nas and it now it works flawless with both magnet links as well http(s) links on the latest version of DownLoad Station. |
Merged fix to develop branch |
Just a FYI Medusa has this same issue with downloadstation 3.8.16.-3566
Sonarr/Sonarr#4388
Downloading an older version of download station from here made medusa start working again:
https://archive.synology.com/download/Package/DownloadStation/3.8.15-3563
Log:
2021-03-18 19:47:15 WARNING SNATCHQUEUE-SNATCH-78125 :: [55cecb9] DownloadStation: Unable to send Torrent
2021-03-18 19:47:15 WARNING SNATCHQUEUE-SNATCH-78125 :: [55cecb9] Error: 'Invalid parameter'
The text was updated successfully, but these errors were encountered: