Workaround to fix an issue with DS 3.8.16.3566. #9401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medariox
reviewed
Apr 3, 2021
| @@ -126,6 +126,10 @@ def _add_torrent_uri(self, result): | |||
| return self._check_response() | |||
|
|
|||
| def _add_torrent_file(self, result): | |||
| # The API in the latest version of Download Station (3.8.16.-3566) | |||
| # is broken for downloading via a file, only uri's are working correct. | |||
| if result.url[:4].lower() in ['http', 'magn']: | |||
There was a problem hiding this comment.
startswith() make is more complex, you have to do two test one for magnet and on for http.
This code test for http, https, and magnet links.
There was a problem hiding this comment.
You can use a tuple like: .startswith(('http', 'magn'))
There was a problem hiding this comment.
There are many ways to Rome mine is tested
There was a problem hiding this comment.
yeah your both right. But i'll go with as is. Tnx for the contribution @BenjV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #9366