Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addic7ed subliminal subtitle provider #10312

Merged
merged 4 commits into from
Feb 5, 2022
Merged

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Feb 5, 2022

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@p0psicles
Copy link
Contributor Author

@nixxou I'm going to add some info to medusa subtitle config page. So users will know that they'll have to replace username with their addic7ed user id.

For now we're overwriting subliminals sub provider with our own. But i'd appreciate it if you'd did a PR to subliminal so that we can get the code in there.

@p0psicles p0psicles merged commit 45b7314 into develop Feb 5, 2022
@p0psicles p0psicles deleted the feature/fix-addic7ed-subs branch February 5, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant