Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back visual indicators for searching, queued and finished. #10566

Merged
merged 17 commits into from
May 31, 2022

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented May 10, 2022

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@p0psicles
Copy link
Contributor Author

p0psicles commented May 10, 2022

@rafi-d could you checkout this branch. And help me out testing as I go through some of your UI issues?
Latest commit should fix the visual indicators for searches in displayShow as well as the history page.

@rafi-d
Copy link
Contributor

rafi-d commented May 12, 2022

^ Just let me know when you are done with most of the changes to save time, and avoid re-updating from github...

@rafi-d
Copy link
Contributor

rafi-d commented May 17, 2022

Add a text underline for Show links. -> working (under hover). Maybe change it to permanent underline, and also change color to blue on hover like you do on the show list.

Fixed width to group and release columns. -> looks Ok to me.

@p0psicles
Don't render show-header until fully switched to new showSlug.
87fad1e
@p0psicles
Further improve switching of shows.

-> original issue - seems ok, show header + banner show w/o previous show. BUT :

  1. showlist drop down menu - sometimes takes forever to even show up (maybe the first time ? with 30 shows), Freezing the GUI.
  2. switching between shows couple of times (drop down) does not work or slow to work (showing FF is slow warning)
  3. Entering a show from the list - takes time after couple of tries

In short - not usable sometimes... :(
clip:
https://drive.google.com/file/d/1KaYzZ9LmfgJbWf80tMWWLtBwlDNvUZ4E/view?usp=sharing
https://drive.google.com/file/d/1KjPMPEXBuM5MI1rVbscWMC4TwajLq7r4/view?usp=sharing

  1. Also added the changes to allow for editing url. Please test.

Seems to work OK.

Medusa Configuration

Medusa Info: Branch: master Commit: e4870f8 Version: 0.5.29 Database: 44.19
Python Version: 3.10.4 (tags/v3.10.4:9d38120, Mar 23 2022, 23:13:41) [MSC v.1929 64 bit (AMD64)]
SSL Version: OpenSSL 1.1.1n 15 Mar 2022
OS: Windows-10-10.0.19042-SP0
Locale: en_IL.cp1255
Timezone: Jerusalem Daylight Time
   
   
User: rafi
Program Folder: D:\Program Files\Medusa\Medusa-feature-ui-enhancements\Medusa-feature-ui-enhancements
Config File: D:\Program Files\Medusa\data - copy2\config.ini
Database File: D:\Program Files\Medusa\data - copy2\main.db
Cache Folder: D:\Program Files\Medusa\data - copy2\cache
Log Folder: D:\Program Files\Medusa\Data\Logs
Arguments: --datadir=D:\Program Files\Medusa\data - copy2
Medusa Configuration Medusa Info: Branch: [master](https://github.com/pymedusa/Medusa/tree/master) Commit: [e4870f8](https://github.com/pymedusa/Medusa/commit/e4870f8f4a322e67c77434597ccc09aa6524aa05) Version: [0.5.29](https://github.com/pymedusa/Medusa/releases/tag/v0.5.29) Database: 44.19 Python Version: 3.10.4 (tags/v3.10.4:9d38120, Mar 23 2022, 23:13:41) [MSC v.1929 64 bit (AMD64)] SSL Version: OpenSSL 1.1.1n 15 Mar 2022 OS: Windows-10-10.0.19042-SP0 Locale: en_IL.cp1255 Timezone: Jerusalem Daylight Time

User: rafi
Program Folder: D:\Program Files\Medusa\Medusa-feature-ui-enhancements\Medusa-feature-ui-enhancements
Config File: D:\Program Files\Medusa\data - copy2\config.ini
Database File: D:\Program Files\Medusa\data - copy2\main.db
Cache Folder: D:\Program Files\Medusa\data - copy2\cache
Log Folder: D:\Program Files\Medusa\Data\Logs
Arguments:

--datadir=D:\Program Files\Medusa\data - copy2

@rafi-d
Copy link
Contributor

rafi-d commented May 17, 2022

There is this too (unrelated I think)

2022-05-17 12:02:59 DEBUG TORNADO :: [e4870f8] Failed doing web ui get request 'destroy': Traceback (most recent call last):
File "D:\Program Files\Medusa\Medusa-feature-ui-enhancements\Medusa-feature-ui-enhancements\medusa\server\web\core\base.py", line 218, in get
method = getattr(self, route)
AttributeError: 'WebRoot' object has no attribute 'destroy'

@p0psicles p0psicles merged commit 4d4b919 into develop May 31, 2022
@p0psicles p0psicles deleted the feature/ui-enhancements branch May 31, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants