-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial provider tests #1794
Initial provider tests #1794
Conversation
Nice :-) |
Take a look in You can just annotate the test method: https://github.com/Diaoul/subliminal/blob/master/tests/test_legendastv.py#L112 And it will do a real request to the site (only first time) and record it in a yaml file: It worth to take a look at it. It might help. If you do use it, don't forget to remove/change your user/password from the generate yaml files before pushing your code to github. |
Thanks for the feedback @ratoaq2. What do you think about the structure? I wanted to avoid having to deal with single tests for each provider (subliminal-like), as they can be hard to maintain, but I'm open to suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a good initiative. Can we rebase and merge it?
@ratoaq2 |
…al use of cassettes instead of html, updated yaml test structure
e6f80d6
to
2e427af
Compare
This is now rebased and fixed. It should work with any provider type, although I just tried with public torrent providers (magnets) for now. Works offline as well after the first run. What should be added is some way to strip the sensitive data from private trackers. I won't have much time this week, but feedback is always appreciated. |
Let's try to get it to a mergeable state. The provider coverage is not important imo. So let's try to have the tests working for a subset. And expand in time. |
@p0psicles |
The PR is now concluded! 🎉 |
Todo:
- [ ] Test with non-ascii results- [ ] Add support for private providers- [ ] Improve codeIncludes: