Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Emby Notifier #4199

Merged
merged 4 commits into from
May 15, 2018
Merged

Update Emby Notifier #4199

merged 4 commits into from
May 15, 2018

Conversation

sharkykh
Copy link
Contributor

  • Add support for indexers other than TVDB by using the show's external ids.
    (Emby's /Library/Series/Updated API only supports TVDB IDs) - Should fix General Update Kodi button not working #4141 (comment)
  • Use MedusaSession instead of urllib
  • Fix flake8 docstring warnings
  • Remove u prefix from strings.

@sharkykh sharkykh added Bug Enhancement Needs review Needs testing Requires testing to make sure it's working as intended labels May 14, 2018
@sharkykh
Copy link
Contributor Author

sharkykh commented May 14, 2018 •
edited
Loading

@Naffles
I would appreciate if you could test this.
Both with the "Test" function on the config page, and by clicking a show's "Update Emby" button.

@NathZ1
Copy link

NathZ1 commented May 14, 2018

Legend! I'm Aussie so walking to work atm. Will test when home tonight. Cheers

@p0psicles p0psicles merged commit 6d9b223 into develop May 15, 2018
@p0psicles p0psicles deleted the feature/update-emby-notifier branch May 15, 2018 17:40
@p0psicles p0psicles added this to the 0.2.3 milestone May 15, 2018
@NathZ1
Copy link

NathZ1 commented May 21, 2018

Can confirm working now working :) Thanks legends!

@sharkykh sharkykh mentioned this pull request Jul 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles approved these changes

Assignees
No one assigned
Labels
Bug Enhancement Needs review Needs testing Requires testing to make sure it's working as intended
Projects
None yet
Milestone
0.2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@sharkykh @NathZ1 @p0psicles