Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guessit to 3.0.0 (+subliminal update) #4244

Merged
merged 56 commits into from
Sep 6, 2018
Merged

Conversation

sharkykh
Copy link
Contributor

@sharkykh sharkykh commented May 23, 2018

@labrys
Copy link
Contributor

labrys commented May 24, 2018

Careful there's a regression in Guessit for titles with periods in it (e.g. Marvel's Agents of S.H.E.I.L.D.) where it drops some of the periods (e.g. S H.E.I.L.D.). Might not be a problem with expected titles, but should be checked.

@sharkykh
Copy link
Contributor Author

sharkykh commented May 25, 2018

@labrys You sure? I get the correct title on both guessit and tests/report_guessit.py.
Can you give me an example filename for it?

Edit: I tried Marvels.Agents.of.S.H.I.E.L.D.S05E22.720p.HDTV.x264-KILLERS

@labrys
Copy link
Contributor

labrys commented May 25, 2018

SSCE

import guessit
guess = guessit.guessit("Marvel's Agents of S.H.I.E.L.D.")
print(guess['title'])
# Marvel's Agents of S H.I.E.L.D.
#                     ^

See guessit-io/guessit#546

@ratoaq2
Copy link
Contributor

ratoaq2 commented May 26, 2018

It also happens in 2.1.4... Upgrading to 3.0 shouldn't be a problem

Conflicts:
	medusa/common.py
	medusa/refiners/tv_episode.py
Remove `'source': 'Web', 'other': 'Rip'` from guessit tests
Conflicts:
	tests/test_common.py
@medariox medariox added Concluded Needs review Needs testing Requires testing to make sure it's working as intended and removed In progress Help wanted labels Aug 30, 2018
@sharkykh

This comment has been minimized.

@sharkykh sharkykh changed the title Update guessit to 3.0.0 Update guessit to 3.0.0 (+subliminal update) Aug 30, 2018
@sharkykh sharkykh added the Update dep (Py) Dependency update (Python) label Sep 1, 2018
@sharkykh sharkykh removed Changelog Requires a changelog entry Do not merge labels Sep 6, 2018
@medariox medariox merged commit c71d8c9 into develop Sep 6, 2018
@medariox medariox deleted the feature/guessit-3 branch September 6, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Concluded Enhancement Needs review Needs testing Requires testing to make sure it's working as intended Priority: 2. Medium Update dep (Py) Dependency update (Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants