convert x-templates to vue SFCs #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0psicles
reviewed
Jul 19, 2018
| } | ||
| }; | ||
| </script> | ||
| <style> |
There was a problem hiding this comment.
Should we make sfc css scoped?
There was a problem hiding this comment.
If you don't want the outside CSS to be able to override the component then yes.
|
EditShow broke with the branch. |
|
@p0psicles any other pages you can see with an issue? |
|
It should be working fine now. |
|
Following pages seem to have broken:
|
|
I would suggest disabling whitespace when you review. |
p0psicles
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to turn off linting for vue files right now as most of the new ones have issues. I'll fix them and re-enable linting in another PR after this.