Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home tabs #4764

Merged
merged 3 commits into from
Jul 27, 2018
Merged

Fix home tabs #4764

merged 3 commits into from
Jul 27, 2018

Conversation

sharkykh
Copy link
Contributor

It seems to work. Javascript seems to still work.

@sharkykh sharkykh added the Needs testing Requires testing to make sure it's working as intended label Jul 27, 2018
@sharkykh sharkykh added this to the 0.2.8 milestone Jul 27, 2018
@sharkykh sharkykh requested a review from p0psicles July 27, 2018 07:23
Copy link
Collaborator

@OmgImAlexis OmgImAlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharkykh

This comment has been minimized.

@sharkykh
Copy link
Contributor Author

Ready to merge.

@OmgImAlexis OmgImAlexis merged commit a866301 into develop Jul 27, 2018
@OmgImAlexis OmgImAlexis deleted the bugfix/split-home-in-tabs branch July 27, 2018 13:03
sharkykh added a commit that referenced this pull request Jul 27, 2018
* Fix home tabs

* Update CHANGELOG.md
@sharkykh sharkykh modified the milestones: 0.2.9, 0.2.8 Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Concluded Needs testing Requires testing to make sure it's working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants