-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python3] Add packages compatible only with python3 (part 2) #4980
Conversation
e8ca93f
to
12b12dd
Compare
adcc257
to
f831403
Compare
0a48899
to
59c85e8
Compare
9c02a1e
to
4d142b1
Compare
4d142b1
to
63d0c1f
Compare
PR rebased. Removed changes related to unrar2 and twitter as they have been fixed in #5096 and #4990 @sharkykh I think this is ready for review. I didn't change any package for python2, just added new packages for python3 in a different folder. Python2 should work as it does now. Code still non working in python3. The first PR with python3 support is #4982 NOTE: I removed ext/_markupbase package because It's not python3 compatible and I think It's not necessary in python2 neither. |
2a73751
to
5b74f55
Compare
@sharkykh in the first commit I duplicated the |
5b74f55
to
e288946
Compare
Sorry, I still don't have time to work on the list...
I don't think you need to go that far. All you have to do is:
Once you import |
e288946
to
15a120a
Compare
@sharkykh Updated PR all DONE!
@p0psicles I saw your changes in #5232 but I think it's not useful. After this PR all packages are compatible with python2 and python3. Even all packages in |
This comment has been minimized.
This comment has been minimized.
0259221
to
53c50e2
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR LGTM. Great job @ngosang 👍
I believe all reveiw comments have been addressed
Creating merge commit, as the commits are just to clean. |
This is the first PR to make pymedusa compatible with python2 and python3 at the same time.
This PR is the 2nd in [Python3] series. Code still non working in python3.
Main discussion: #4975
You wanna help?
TODO:
GitUpdateManager.clean
instead of adding new code. Rework after Fix unable to start Medusa due to configparser ImportError #5145GitUpdateManager.clean
with the new folders.Medusa/medusa/version_checker.py
Line 708 in 1435fcb
ext3/sgmllib
packageext3/bs4
package (same version asext/bs4
)ext3/github
package (same version asext/github
)ext3/yaml
after Update bencode and PyYAML #5140 is merged.Addext3/yaml
package (same version asext/yaml
)ext3/httplib2
after Remove unused Python libraries #5091 is merged.Addext3/httplib2
packagelib3/bencode
after Update bencode and PyYAML #5140 is merged.Addlib3/bencode
packagelib/unrar2
. Done in Update lib unrar2 (python2 and python3 supported) #5096I updatedlib/unrar2
lib for both python2 and python3. Please test it still works in python2.ext/pythontwitter
. Done in Update Twitter notifier #4990The
ext/pythontwitter
package is really old and not compatible with python3. I added 2 new packages inext3/pythontwitter
andext3/requests_oauthlib
. These packages are only used in python3 (because I can't test in python2) but should work with python2 also. Please copy:ext3/pythontwitter => ext/pythontwitter
(overwrite)ext3/requests_oauthlib => ext3/requests_oauthlib
Libraries non compatible with python3 but the code works if you don't use that features (will be fixed in other PRs):
Disclaimer: