-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update /series
API to only get AniDB data if requested
#5166
Conversation
Only fetch AniDB info when it is set to `True` (default is `False`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I dont see this as the most desirable solution. I think we should eventually move the anidb fetch logic to a separate endpoint. Meaning we can always load the page fast. But for now its good enough |
* Add `fetch` argument to `/series` API endpoint Only fetch AniDB info when it is set to `True` (default is `False`) * Update editShow to get AniDB data * Update store/shows actions * Lint JS * Update changelog # Conflicts: # CHANGELOG.md # themes/dark/assets/js/vendors.js # themes/light/assets/js/vendors.js
Haha, you mean like |
Haha. Yeah but preferebly restfull |
@p0psicles you seem to put RPC calls and REST into the same basket. Fetching would be an action. REST endpoint can have actions that run in the background and return data over another transport(websocket) or on the next If you want to just add RPC calls then do that but please don't mix them. |
I dont mix them. I said i prefer a restfull solution. Didnt say we should use 'fetch' restfull |
I know that but you're talking about moving an ACTION not a RESOURCE to an endpoint. |
Okay sorry for the confusion. I like to not start adding rpc. And prefer to add a rest reaource that can be used the get releasegroups. Like /series/id/releasegroups/operation |
Oh okay so the fetch + cache results would be there not just the fetching? |
fetch
argument to/series
API endpointOnly fetch AniDB info when it is set to
True
(default isFalse
)editShow
to get AniDB dataThis will fix the calls to AniDB (for every anime show in the library) when navigating to
displayShow
for a show of any type (normal or anime).Closes #5170