Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Speedcd parsing and add pubdate #5190

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Fix Speedcd parsing and add pubdate #5190

merged 3 commits into from
Sep 11, 2018

Conversation

medariox
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@medariox medariox added this to the 0.2.11 milestone Sep 10, 2018
@medariox medariox closed this Sep 10, 2018
@medariox medariox reopened this Sep 10, 2018
sharkykh
sharkykh previously approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@sharkykh sharkykh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM
Should probably also update the changelog?

@duramato
Copy link
Contributor

Added the missing RERIP while we're touching the provider. @medariox

@medariox
Copy link
Contributor Author

@sharkykh Done 👍

@p0psicles p0psicles merged commit dd8ba3b into develop Sep 11, 2018
@p0psicles p0psicles deleted the feature/fix-speedcd branch September 11, 2018 15:10
@medariox medariox mentioned this pull request Sep 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkykh sharkykh sharkykh approved these changes

Assignees
No one assigned
Labels
Bug Concluded Enhancement
Projects
None yet
Milestone
0.2.11
Development

Successfully merging this pull request may close these issues.
4 participants
@medariox @duramato @sharkykh @p0psicles