-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: Allow use of Pushover priorities. #5567
New feature: Allow use of Pushover priorities. #5567
Conversation
Also, set default Pushover alert sound to whatever is configured on the receiving device, and fixed bug where unsuccessful notification were not being detected.
DeepCode analyzed this pull request. |
Sorry for the errors. Is fixed here.. Should be merged today |
DeepCode analyzed this pull request. |
No problems. I'll test this out now that #5557 has been merged and confirm shortly that this PR is tested and ready. |
Looks good. This is ready to go. |
You need to run yarn dev in the slim folder |
DeepCode analyzed this pull request. |
Also, set default Pushover alert sound to whatever is configured on the receiving device, and fixed bug where unsuccessful notification were not being detected.
Also, the current
Develop
branch has an issue on the notifications page, spitting out a bunch of JS errors which are preventing the Enable toggle switches from displaying the relevant fields (this has occurred after #4913 was merged):