Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow to set anime option(s) when adding shows through tmdb or… #5701

Merged
merged 6 commits into from
Nov 14, 2018
Merged

Do not allow to set anime option(s) when adding shows through tmdb or… #5701

merged 6 commits into from
Nov 14, 2018

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Nov 12, 2018 •
edited
Loading

… tvmaze.

Update changelog.

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@ghost
Copy link

ghost commented Nov 12, 2018

DeepCode analyzed this pull request.
There are no new issues.

@p0psicles
Copy link
Contributor Author

@sharkykh @OmgImAlexis @MrTimscampi what do you guys think?
I see allot issues reported now from users that use tvmaze or tmdb to add anime.
The issue is, that the scene numbering column in the db is not properly populated. You can see that because it tries to use episode 00 to search.

So there are a number of underlying bugs / restrictions, why tvmaze and tmdb should be omitted for anime. Like for ex, that we can't map tmdb to scene numbering from xem.

I think best is now, to disallow to set anime for these indexers.
@MrTimscampi when you split the anime from the numbering, this should get attention.

@p0psicles p0psicles added this to the 0.2.12 milestone Nov 13, 2018
@ghost
Copy link

ghost commented Nov 14, 2018

DeepCode analyzed this pull request.
There are no new issues.

OmgImAlexis
OmgImAlexis reviewed Nov 14, 2018
View reviewed changes
themes-default/slim/views/addShows_newShow.mako Outdated
@@ -609,7 +615,7 @@ window.app = new Vue({
<fieldset class="sectionwrap">
<legend class="legendStep">Customize options</legend>
<div class="stepDiv">
<add-show-options :show-name="showName" enable-anime-options @change="updateOptions" @refresh="refreshOptionStep"></add-show-options>
<add-show-options :show-name="showName" :enable-anime-options="enableAnimeOptions" @change="updateOptions" @refresh="refreshOptionStep"></add-show-options>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use v-bind for the ones with the same name.

OmgImAlexis
OmgImAlexis approved these changes Nov 14, 2018
View reviewed changes
Copy link
Collaborator

@OmgImAlexis OmgImAlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p0psicles p0psicles merged commit cac1de7 into develop Nov 14, 2018
@p0psicles p0psicles deleted the feature/disable-anime-options-non-tvdb branch November 14, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmgImAlexis OmgImAlexis OmgImAlexis approved these changes

Assignees
No one assigned
Labels
Concluded Enhancement
Projects
None yet
Milestone
0.2.12
Development

Successfully merging this pull request may close these issues.
2 participants
@p0psicles @OmgImAlexis