Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add ignored required exclude option #6033

Merged
merged 11 commits into from
Jan 24, 2019

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Jan 17, 2019

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

This feature will add flags that change the behavior of the required words and ignored words fields for the tv_show configuration. Enabling the flag will make sure that the words provided in the shows configuration, will be excluded from the global configuration.

Will implement #5648

TODO:

  • Implement unit tests
  • Implement logic in Series.show_words() method
  • Add new options in db main.db tv_shows
  • Add new options in UI
  • Update api spec
  • Update api unit test
  • Update changelog

image

@ghost
Copy link

ghost commented Jan 17, 2019

DeepCode analyzed this pull request.
There are no new issues.

@udochrist
Copy link

Looking at the GUI this seems ok.
My use case is to remove a single word from the global ignore list on a single show.

@medariox medariox merged commit 967332c into develop Jan 24, 2019
@medariox medariox deleted the feature/add-ignored-required-exclude-option branch January 24, 2019 09:10
@udochrist
Copy link

hmmm. in medusa 3,o the GUI is missing the select boxes for excluded/ignored. is the final implementation. different from this feature?

@medariox
Copy link
Contributor

Which boxes are you referring to? Final implementation should be the same. Try a hard cache refresh with CTRL + F5.

@udochrist
Copy link

YES. that fixed it. after clearing the cache the toggle buttons appeared.

great work with 0.3.0 and thanks for the fast reply!

@scott451
Copy link

hello. i looked at this new feature. in my install it looks like the global ignore words are used for ignore words and required words as well. though adding exceptions works correctly.

@medariox
Copy link
Contributor

@scott451
Please open a new issue, this is not the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants