Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nCore torrent provider #6537

Merged
merged 9 commits into from
Apr 26, 2019
Merged

Add nCore torrent provider #6537

merged 9 commits into from
Apr 26, 2019

Conversation

medariox
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Big thanks to @ExPeacer for providing access to the provider.

@ghost
Copy link

ghost commented Apr 19, 2019

DeepCode analyzed this pull request.
There are 3 new warnings and 16 new info reports. 2 info reports were fixed.

Click to see more details.

@medariox medariox changed the title Feature/add ncore Add nCore torrent provider Apr 19, 2019
medusa/providers/torrent/json/ncore.py Outdated Show resolved Hide resolved
# Cache
self.cache = tv.Cache(self, min_time=20)

def search(self, search_strings, age=0, ep_obj=None, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove age and ep_obj. I don't think you need to put *args. The **kwargs should pick them up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just shadows how it is implemented in generic_provider. If we need to change it, we should change it for every other provider as well.

@medariox medariox added the Bug label Apr 19, 2019
@medariox medariox merged commit e769480 into develop Apr 26, 2019
@medariox medariox deleted the feature/add-ncore branch April 26, 2019 15:09
@medariox medariox mentioned this pull request Apr 26, 2019
Thilas pushed a commit to Thilas/Medusa that referenced this pull request Jun 5, 2019
* Add nCore torrent provider

* Small changes and fixes

* rm ln

* Fix snatching seasons when there aren't any single episode results

* rename to ncore

* Update CHANGELOG.md

* don't use try_int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants